User and community avatar support in chips #1318
Conversation
There was a problem hiding this comment.
The code LGTM! Nice work, as always!
I only have one question.
- Settings -> Appearance -> Comments -> Show User Avatar
- Settings -> Appearance -> Posts -> Post Body Settings -> Show Community Avatar
Since the avatars may appear in other areas than these specifically (e.g., right now, the user avatar will appear in the post body, and in the future they may appear in the feed too), should these settings go under Appearance > Theming > Names?
(This is just an idea and I'd wait to hear @hjiangsu chime in first!)
Hmm, I think for now, we can leave them in their respective places. If the amount of settings become large enough, I was thinking of creating a new page to customize user/community avatars and chips under |
That makes sense to me! We could also put "Use Display Names" for both users and communities there! |
|
Yup, we don't have to do that in this PR though - it can be done separately! I'll go ahead and merge this one in. Thanks @iparks99 for the contribution again! |
Pull Request Description
Added toggle options to:
Wherever there is a User/Community Chip widget, the User/Community's avatar will be displayed if the appropriate toggle option is set to true.
Issue Being Fixed
Enhancement to display user and community avatars in post view.
Issue Number: #600, #1221
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?